Re: [PATCH 4/4] acpi,memory-hotplug : store the node id in acpi_memory_device

[KOSAKI Motohiro]

On Mon, Oct 8, 2012 at 2:47 AM, Wen Congyang <wency@xxxxxxxxxxxxxx> wrote:
> At 10/06/2012 02:56 AM, KOSAKI Motohiro Wrote:
>> On Wed, Oct 3, 2012 at 6:11 AM, Yasuaki Ishimatsu
>> <isimatu.yasuaki@xxxxxxxxxxxxxx> wrote:
>>> From: Wen Congyang <wency@xxxxxxxxxxxxxx>
>>>
>>> The memory device has only one node id. Store the node id when
>>> enable the memory device, and we can reuse it when removing the
>>> memory device.
>>
>> You don't explain why we need this. Then nobody can review nor ack.
>>
>
> This patch doesn't fix any problem. Its purpose is: avoid to calculate
> the node id twice.

ditto.

Please separate patches as logical change. You should make problem fix
patch set.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/