Re: [PATCH] Drivers: Staging: CSR: made corrections on theindentation errors

[Greg KH]

On Sun, Oct 14, 2012 at 08:20:11PM +0900, Sangho Yi wrote:
> Originally there were a lot mis-indentation, so I made changes to use
> only the tabs (no spaces) on indenting code.
> - Still, the typedef struct ... tells warning message on checkpatch.pl.

Yes, we shouldn't be using a typedef, but why did you change the typedef
itself:

> -typedef struct
> -{
> -    u32 sec;
> -    u16 msec;
> +typedef struct _CsrTimeUtc {
> +	u32 sec;
> +	u16 msec;
>  } CsrTimeUtc;

Why add the _CsrTimeUtc here?  That's not really needed, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/