RE: Fix memory leak in cpufreq stats.

From: Tu, Xiaobing
Date: Mon Oct 15 2012 - 03:04:02 EST


+alex

-----Original Message-----
From: Tu, Xiaobing
Sent: Monday, October 15, 2012 10:48 AM
To: 'davej@xxxxxxxxxx'; 'akpm@xxxxxxxxxxxxxxxxxxxx'; 'mingo@xxxxxxx'; 'rusty@xxxxxxxxxxxxxxx'; 'a.p.zijlstra@xxxxxxxxx'; 'linux-kernel@xxxxxxxxxxxxxxx'; 'rostedt@xxxxxxxxxxx'
Cc: Tang, Guifang; Tu, Xiaobing
Subject: Fix memory leak in cpufreq stats.


Fix memory leak in cpufreq stats.

When system enter sleep, non-boot CPUs will be disable.
Cpufreq stats sysfs is created when the CPU is up, but it is not freed when the CPU going down. This will cause memory leak.
signed-off-by: xiaobing tu <xiaobing.tu@xxxxxxxxx>
signed-off-by: guifang tang <guifang.tang@xxxxxxxxx>

diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c index b40ee14..3998316 100644
--- a/drivers/cpufreq/cpufreq_stats.c
+++ b/drivers/cpufreq/cpufreq_stats.c
@@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
cpufreq_update_policy(cpu);
break;
case CPU_DOWN_PREPARE:
+ case CPU_DOWN_PREPARE_FROZEN:
cpufreq_stats_free_sysfs(cpu);
break;
case CPU_DEAD:

Br
XiaoBing Tu
PSI@System Integration Shanghai


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/