Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

[Roland Stigge]

On 10/15/2012 08:07 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 21:11 Fri 12 Oct     , Roland Stigge wrote:
>> This patch adds sysfs support to the block GPIO API.
>>
>> Signed-off-by: Roland Stigge <stigge@xxxxxxxxx>
>>
>> ---
>>  Documentation/ABI/testing/sysfs-gpio |    6 
>>  drivers/gpio/gpiolib.c               |  226 ++++++++++++++++++++++++++++++++++-
>>  include/asm-generic/gpio.h           |   11 +
>>  include/linux/gpio.h                 |   13 ++
>>  4 files changed, 254 insertions(+), 2 deletions(-)
> I really don't like this sysfs we need to add a specific device with ioctl

The good thing about the current style is that you have a single value
for the whole block in a single file just as for single GPIOs. You can
consider it as a generalized GPIO.

And I like it. :-)

Thanks for considering,

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/