Re: [PATCH] dmatest: terminate all ongoing transfers beforesubmitting new one

From: Andy Shevchenko
Date: Tue Oct 16 2012 - 06:14:43 EST


On Tue, Oct 16, 2012 at 12:52 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>>> Also, the proposed solution might hide some other important errors. We may need
>>> to terminate transfers when we found that an error is there in last transfers:
>> I think it could be better than first solution, but what do you think
>> about marking each transfer with corresponding id?
>
> But dma_test expects the transfer to finish within timeout. If it
> doesn't, then that's
> an error.
>
> So, for testing your s/w emulation, you must pass higher timeout. And
> terminating
> transfers for error case would be better, to make them timeout safe.

Yeah, seems the patch is not necessary.
In case of software emulation we just have a test passed much slow...

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/