Re: [PATCH] avr32: fix build error in atstk1006_defconfig
From: Håvard Skinnemoen
Date: Tue Oct 16 2012 - 14:04:35 EST
On Tue, Oct 16, 2012 at 12:19 AM, Josh Wu <josh.wu@xxxxxxxxx> wrote:
> fixed the following compile error when use avr32 atstk1006_defconfig:
> drivers/mtd/nand/atmel_nand.c: In function 'pmecc_err_location':
> drivers/mtd/nand/atmel_nand.c:639: error: implicit declaration of function 'writel_relaxed'
> which was introduced by commit 1c7b874d33b463 ("mtd: at91: atmel_nand: add Programmable Multibit ECC controller support").
> The PMECC for nand flash code uses writel_relaxed(). But in avr32, there is no macro "writel_relaxed" defined. This patch add writex_relaxed macro definitions.
> Signed-off-by: Josh Wu <josh.wu@xxxxxxxxx>
Acked-by: Havard Skinnemoen <havard@xxxxxxxxxxxxxx>
I think it's OK to just forward to write[bwl] -- the relaxed variants
merely provide fewer ordering guarantees than the non-relaxed
variants. The worst that could happen is a small performance hit (and
on AVR32, even that is highly unlikely).
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/