[PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq

From: Chuansheng Liu
Date: Tue Oct 16 2012 - 21:12:27 EST



When destroying the irq, before free cfg, need to check
cfg->irq_2_pin and free it when it is not NULL.

Signed-off-by: liu chuansheng <chuansheng.liu@xxxxxxxxx>
---
arch/x86/kernel/apic/io_apic.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index c265593..a976ee3 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -201,6 +201,15 @@ static struct irq_pin_list *alloc_irq_pin_list(int node)
return kzalloc_node(sizeof(struct irq_pin_list), GFP_KERNEL, node);
}

+static void free_irq_pin_list(struct irq_cfg *cfg)
+{
+ struct irq_pin_list *entry, *next;
+
+ for (entry = cfg->irq_2_pin; entry; entry = next) {
+ next = entry->next;
+ kfree(entry);
+ }
+}

/* irq_cfg is indexed by the sum of all RTEs in all I/O APICs. */
static struct irq_cfg irq_cfgx[NR_IRQS_LEGACY];
@@ -276,6 +285,7 @@ static void free_irq_cfg(unsigned int at, struct irq_cfg *cfg)
irq_set_chip_data(at, NULL);
free_cpumask_var(cfg->domain);
free_cpumask_var(cfg->old_domain);
+ free_irq_pin_list(cfg);
kfree(cfg);
}

--
1.7.0.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/