Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

From: Arve Hjønnevåg
Date: Tue Oct 16 2012 - 23:35:47 EST

On Fri, Oct 5, 2012 at 12:48 PM, Mathieu Poirier
<mathieu.poirier@xxxxxxxxxx> wrote:
> On 12-10-05 12:16 PM, Dmitry Torokhov wrote:
>> On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poirier@xxxxxxxxxx wrote:
>>> From: "Mathieu J. Poirier" <mathieu.poirier@xxxxxxxxxx>
>>> Andrew,
>>> After requesting a number of changes that, to my understanding
>>> have been implemented, I have not been able to get the attention
>>> of the subsystem maintainer on this patch.
>>> If there are still issues, I'm open to making changes but I want
>>> to make sure it doesn't get forgotten. If there no objections,
>>> would you consider queuint it ?
>> Mathieu,
>> I have the same objection as before: using platform device solely for
>> the purpose of passing some data from board code to the driver. Surely
>> there are other ways of passing this bit of data... What about, for
>> example, making it an empty weak symbol so that board code could
>> override it with strong one?
> Thanks for the comments - I will implement a weak function in the
> keyreset driver.

A weak symbol does not work. A single kernel can support multiple
devices that have unique reset key combinations.

Arve Hjønnevåg
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at