Re: [PATCH 02/10] UAPI: Make uapi/linux/irqnr.h non-empty

From: Geert Uytterhoeven
Date: Wed Oct 17 2012 - 10:47:52 EST

On Wed, Oct 17, 2012 at 4:15 PM, David Howells <dhowells@xxxxxxxxxx> wrote:
> uapi/linux/irqnr.h was emitted by the UAPI disintegration script as an empty
> file because the parent linux/irqnr.h had no UAPI stuff in it, despite being
> marked with "header-y".

> --- a/include/uapi/linux/irqnr.h
> +++ b/include/uapi/linux/irqnr.h
> @@ -0,0 +1,4 @@
> +/*
> + * There isn't anything here anymore, but the file must not be empty or patch
> + * will delete it.
> + */

Wouldn't it be better to just have include guards in those otherwise
empty files?

If someone needs to add something to such a file, the include guards are needed
anyway (but may be forgotten), and the comment should be deleted as well
(which may also be forgotten).

BTW, is "#pragma once" allowed these days? It seems we already have one
user in drivers/staging/bcm/CmHost.h.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at