Re: [PATCH] Do not use cpu_to_node() to find an offlined cpu'snode.
From: David Rientjes
Date: Wed Oct 17 2012 - 20:52:47 EST
On Wed, 10 Oct 2012, David Rientjes wrote:
> It fixes a BUG() that only affects users who are doing node hot-remove,
> which is still radically under development, and nobody cares about except
> those on the cc list, but it also introduces the NULL pointer dereference
> that is attempting to be addressed in this patch. The "fix" that causes
> this NULL pointer is clearly not the direction we want to go, I think we
> have agreement at node hot-remove to iterate all possible cpus are map all
> offline cpus with cpu_to_node(cpu) == node to NUMA_NO_NODE instead in the
> generic hotplug code.
> Regardless, this shouldn't be touching the acpi code which
> cpu_hotplug-unmap-cpu2node-when-the-cpu-is-hotremoved.patch and
> cpu_hotplug-unmap-cpu2node-when-the-cpu-is-hotremoved-fix.patch do since
> it makes the behavior inconsistent across interfaces and architectures.
Ok, so it's been a week and these patches are still in -mm. This is what
I was afraid of: patches that both Peter and I nacked sitting in -mm and
allow a NULL pointer dereference because no alternative patch exists yet
to fix the issue correctly.
Tang and Wen, are you intending on addressing these problems (i.e. not
touching the acpi code at all and rather clearing cpu-to-node mappings at
node hot-remove) as we've discussed or do I need to do it myself?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/