Re: [PATCH 5/6] xen: arm: implement remap interfaces needed forprivcmd mappings.
From: Ian Campbell
Date: Thu Oct 18 2012 - 09:47:03 EST
On Thu, 2012-10-18 at 14:35 +0100, Stefano Stabellini wrote:
> On Thu, 18 Oct 2012, Ian Campbell wrote:
> > On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote:
> > > On Wed, 17 Oct 2012, Ian Campbell wrote:
> > > > We use XENMEM_add_to_physmap_range which is the preferred interface
> > > > for foreign mappings.
> > > >
> > > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > >
> > > It looks OK but there are few code style issues, please run the patch
> > > through checkpatch.
> > The only one I get is:
> > WARNING: please, no spaces at the start of a line
> > #83: FILE: include/xen/interface/memory.h:175:
> > + uint16_t size;$
> > total: 0 errors, 1 warnings, 64 lines checked
> > The prevailing indentation in that file is 4 spaces so I think we should
> > ignore the warning in this case in the interests of consistency with the
> > surrounding code.
> Strange, I get:
I'm running v3.7-rc1-187-g7bbf07e so it is pretty recent.
> total: 2 errors, 6 warnings, 162 lines checked
Ah, I was looking at patch 6/6...
The warnings in this one are all of the same class as before (4 space
indentation). But you are right, the other two need fixing. Done in my
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/