Re: [PATCH] pinctrl: reserve pins when states are activated

From: Stephen Warren
Date: Thu Oct 18 2012 - 19:33:18 EST

On 10/18/2012 04:01 AM, Linus Walleij wrote:
> This switches the way that pins are reserved for multiplexing:

The conceptual change makes perfect sense to me.

> diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c

> void pinmux_free_setting(struct pinctrl_setting const *setting)
> + /*
> + * If a setting is active, disable it so that all pins are released
> + */
> + pinmux_disable_setting(setting);

"*If* a setting is active ..." implies there should be a C if statement
here to check if the setting is actually active before trying to disable it?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at