Re: [PATCH] remove untouched code in kfifo_in
From: Jiri Kosina
Date: Fri Oct 19 2012 - 03:34:41 EST
On Fri, 19 Oct 2012, Stefani Seibold wrote:
> > > In kfifo_in marco, one piece of code is arounded by if(0). This code in
> > > introduced by Stefani Seibold <stefani@xxxxxxxxxxx> to suppress a compiler
> > > warning. This warning is not there with the upgrade of gcc version.
> > >
> > > This patch just remove this code.
> > Are you sure?
> > This code fragment looks like a compiler bomb to detect type mismatch to me...
> Yes, you are great! That was the reason why i made this peace of code.
> So don't remove it!
As even you, the author of the code, got confused by it for a while,
adding an explanatory comment seems appropriate.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/