Re: [PATCH 1/3] mm/slob: Drop usage of page->private for storingpage-sized allocations

From: Ezequiel Garcia
Date: Fri Oct 19 2012 - 08:31:32 EST

On Thu, Oct 18, 2012 at 7:46 PM, David Rientjes <rientjes@xxxxxxxxxx> wrote:
> On Thu, 18 Oct 2012, Ezequiel Garcia wrote:
>> This field was being used to store size allocation so it could be
>> retrieved by ksize(). However, it is a bad practice to not mark a page
>> as a slab page and then use fields for special purposes.
>> There is no need to store the allocated size and
>> ksize() can simply return PAGE_SIZE << compound_order(page).
>> Cc: Pekka Penberg <penberg@xxxxxxxxxx>
> Is Pekka Penberg the long distant cousin of Pekka Enberg? :) You should
> probably cc the author of slob, Matt Mackall <mpm@xxxxxxxxxxx>, on slob
> patches.

Ouch! ;-)

I found another typo so I'll just re-send the whole patchset.

Thanks for the review!

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at