Re: [PATCH v4 2/2] block: Convert integrity to bvec_alloc_bs()
From: Vivek Goyal
Date: Fri Oct 19 2012 - 14:11:04 EST
On Mon, Oct 15, 2012 at 01:09:02PM -0700, Kent Overstreet wrote:
> This adds a pointer to the bvec array to struct bio_integrity_payload,
> instead of the bvecs always being inline; then the bvecs are allocated
> with bvec_alloc_bs().
> Changed bvec_alloc_bs() and bvec_free_bs() to take a pointer to a
> mempool instead of the bioset, so that bio integrity can use a different
> mempool for its bvecs, and thus avoid a potential deadlock.
> This is eventually for immutable bio vecs - immutable bvecs aren't
> useful if we still have to copy them, hence the need for the pointer.
> Less code is always nice too, though.
I think this patch should be part of your immutable prep work series or
later series. First patch is the stand alone fix for bio integrity for
bio_split() case. I would say post that separately and hopefully martin
likes it and acks it. It is simple enough and looks right to me though.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/