Re: [PATCH 1/2] Staging: android: binder: Fix memory leak onthread/process exit

[Greg KH]

On Tue, Oct 16, 2012 at 03:45:20PM -0700, Arve Hjønnevåg wrote:
> On Tue, Oct 16, 2012 at 12:11 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, Oct 15, 2012 at 05:32:41PM -0700, Arve Hjønnevåg wrote:
> >> If a thread or process exited while a reply, one-way transaction or
> >> death notification was pending, the struct holding the pending work
> >> was leaked.
> >>
> >> Change-Id: I2eaafaba1c0ecda3ec0872d449dc16d0721c21e7
> >
> > What is this field?  Please don't include this in kernel patches, it
> > forces me to edit the patch by hand :(
> >
> 
> It is a tag generated a git hook to uniquely identify a change through
> multiple revisions of that change. If the tag does not already exist
> the hook adds it. I removed it from the reposted patches as you
> requested, but have you considered leaving it in? It is a useful
> search token both for finding different revisions of a patch and for
> finding which branch a change has been cherry-picked into.

Sorry, I was being facetious, I knew what it really was, but the point
was, why would I?

As has been stated before, you can include information like this in your
patch, but you MUST reference it properly so that others can be able to
figure out what you mean.  A random Change-Id value means nothing given
that lots of different groups use gerrit.  You need a url, or a pointer
to which gerrit instance this refers to before you can include it.

Same goes for bugzilla entries, if you look in the kernel changelog, we
reference lots of different ones, but we use urls to determine which one
we are talking about (suse, red hat, kernel.org, etc.)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/