Re: [GIT PULL] UAPI: perf fixes
From: Josh Boyer
Date: Mon Nov 12 2012 - 15:23:42 EST
On Thu, Nov 8, 2012 at 7:51 AM, David Howells <dhowells@xxxxxxxxxx> wrote:
>
> (6) Make perf work for x86 by adding -I flags and changing long #includes
> with "../../include" in them into short <asm/foo.h> type things.
This patch seems to break building perf on ppc64. It fails with:
+ make -j16 -C tools/perf -s V=1 WERROR=0 HAVE_CPLUS_DEMANGLE=1 prefix=/usr all
<snip>
builtin-kvm.c:25:21: fatal error: asm/svm.h: No such file or directory
compilation terminated.
make: *** [builtin-kvm.o] Error 1
make: *** Waiting for unfinished jobs....
And that is indeed because arch/powerpc/include/asm/svm.h doesn't exist
(and therefore can't be exported like the first patch for x86 in this
series does). You can find full build logs with this patch series
applied here: http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=781782
However, without some form of fix for the ../.. includes, perf still
fails to build on arches like ARM and powerpc with errors like this:
In file included from util/../perf.h:29:0,
from util/cache.h:7,
from util/quote.c:1:
util/../../../arch/powerpc/include/asm/unistd.h:12:29: fatal error:
uapi/asm/unistd.h: No such file or directory
compilation terminated.
make: *** [util/parse-events-test.o] Error 1
Full build logs here:
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=781076
So. Something else might need to be done to fix perf builds for non-x86
arches.
josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/