Re: [PATCH 3/6] dma: dw_dmac: check direction properly indw_dma_cyclic_prep

[Felipe Balbi]

On Fri, Nov 16, 2012 at 03:59:16PM +0200, Andy Shevchenko wrote:
> dma_transfer_direction is a normal enum. It means we can't usually use the
> values as bit fields. Let's adjust this check and move it above the usage of
> the direction parameter.

why above the direction parameter ? You need to explain why ? Is it just
because 'it looks nicer' or have you found another bug triggered by
that ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature