Re: [PATCH 3/6] dma: dw_dmac: check direction properly indw_dma_cyclic_prep

[Felipe Balbi]

Hi,

On Fri, Nov 16, 2012 at 05:30:21PM +0200, Andy Shevchenko wrote:
> On Fri, Nov 16, 2012 at 3:56 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> > On Fri, Nov 16, 2012 at 03:59:16PM +0200, Andy Shevchenko wrote:
> >> dma_transfer_direction is a normal enum. It means we can't usually use the
> >> values as bit fields. Let's adjust this check and move it above the usage of
> >> the direction parameter.
> >
> > why above the direction parameter ? You need to explain why ? Is it just
> > because 'it looks nicer' or have you found another bug triggered by
> > that ?
> 
> Many of current users do something like this:
> 
> if (dir == MEM_TO_DEV)
>  { ... }
> *else*
>  { ... }
> 
> that potentially could trigger the bug.

looks like this deserves to go into commit log ;-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature