Re: [PATCH 2/2] drivres/power/jz4740-battery.c: Usedevm_request_and_ioremap

From: Anton Vorontsov
Date: Sun Nov 18 2012 - 19:15:07 EST


On Fri, Nov 09, 2012 at 10:42:11AM +0100, Lars-Peter Clausen wrote:
> On 11/07/2012 12:11 AM, Marcos Paulo de Souza wrote:
> > No functional changes. Just a cleanup.
> >
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@xxxxxxxxx>
>
> Looks good to me:
>
> Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

Thanks for the patches and for the reviews!

> One minor comment though:
[...]
> devm_request_and_ioremap will print its own error messages if it fails, so
> strictly speaking this is not necessary, but I don't think it is worth doing
> resend just for this.

> Anton, maybe you can just remove the line when applying the patch.

Sure, I fixed it up and applied.

Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/