Re: [PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

[Dmitry Torokhov]

On Tue, Nov 20, 2012 at 01:26:29PM +0530, Viresh Kumar wrote:
> On 12 November 2012 11:27, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > On 8 November 2012 19:10, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> >> From: Vipul Kumar Samar <vipulkumar.samar@xxxxxx>
> >>
> >> clk_{un}prepare is mandatory for platforms using common clock framework. Because
> >> for SPEAr we don't do anything in clk_{un}prepare() calls, just call them ones
> >> in probe/remove.
> >>
> >> Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@xxxxxx>
> >> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> >
> > Missed applying this one ?
> 
> This one you missed :)

No, not really, it just does not work well with devm_* patches that got
applied: on removal you unprepare clock as the very first operation and
then devm_* does the rest which is wrong order.

I am looking at adding dem_* for clocks.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/