Re: [PATCH] x86, smpboot: allow manual hotplug of CPUs

[Sasha Levin]

On 11/21/2012 01:38 PM, H. Peter Anvin wrote:
> On 11/21/2012 10:35 AM, Sasha Levin wrote:
>>>
>>> Reading between the lines, this sounds like would cause a user-visible
>>> difference between mptable platforms and ACPI platforms?  If so, that is
>>> totally unacceptable.  If not, the description is confusing.
>>
>> With ACPI platforms you don't need probe/release because the hardware notifies
>> on CPU insert/eject - this doesn't exist on mptable which is why you have to
>> do it manually with probe/release.
>>
>> The difference is already user visible: you can hotplug on ACPI, but can't on
>> mptables.
>>
>> Yes, reading back the subject does sound confusing - a better one would probably
>> be "provide interface for CPU hotplug on mptable platforms" or something similar.
>>
> 
> So, are there any mptables platforms which support hotplug?  If the
> answer is "KVM" then the answer is that KVM needs to move to ACPI to get
> the proper functionality; putting a hack in is really not okay.

There are no platforms which support actual hotplug, but you can still set
existing processors as disabled in the table and without this patch there's
no way enable them.

I'm not sure if it's a "hack" though - the presentation of hotpluggable cpus
is the almost the same between mptable and acpi, and acpi provides a way to
manually probe/release cpus as well. The only difference is that acpi also
provides notifications about such events.

Actually, maybe acpi should start using probe/release as well... hmm...


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/