Re: [PATCH 36/46] mm: numa: Use a two-stage filter to restrict pagesbeing migrated for unlikely task<->node relationships

From: Ingo Molnar
Date: Thu Nov 22 2012 - 17:21:31 EST



* Rik van Riel <riel@xxxxxxxxxx> wrote:

> On 11/21/2012 02:15 PM, Mel Gorman wrote:
> >On Wed, Nov 21, 2012 at 07:25:37PM +0100, Ingo Molnar wrote:
>
> >>As mentioned in my other mail, this patch of yours looks very
> >>similar to the numa/core commit attached below, mostly written
> >>by Peter:
> >>
> >> 30f93abc6cb3 sched, numa, mm: Add the scanning page fault machinery
>
> >Just to compare, this is the wording in "autonuma: memory follows CPU
> >algorithm and task/mm_autonuma stats collection"
> >
> >+/*
> >+ * In this function we build a temporal CPU_node<->page relation by
> >+ * using a two-stage autonuma_last_nid filter to remove short/unlikely
> >+ * relations.
>
> Looks like the comment came from sched/numa, but the original
> code came from autonuma:
>
> https://lkml.org/lkml/2012/8/22/629

Yeah, indeed, good find - thanks for tracking that down - to me
it came from Peter. I'll add in an explicit credit to Andrea,
the comment alone deserves one!

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/