Re: [net-next RFC] pktgen: don't wait for the device who doesn'tfree skb immediately after sent

[Jason Wang]

On 11/27/2012 01:37 AM, Stephen Hemminger wrote:
> On Mon, 26 Nov 2012 15:56:52 +0800
> Jason Wang <jasowang@xxxxxxxxxx> wrote:
>
> > Some deivces do not free the old tx skbs immediately after it has been sent
> > (usually in tx interrupt). One such example is virtio-net which optimizes for
> > virt and only free the possible old tx skbs during the next packet sending. This
> > would lead the pktgen to wait forever in the refcount of the skb if no other
> > pakcet will be sent afterwards.
> >
> > Solving this issue by introducing a new flag IFF_TX_SKB_FREE_DELAY which could
> > notify the pktgen that the device does not free skb immediately after it has
> > been sent and let it not to wait for the refcount to be one.
> >
> > Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
> Another alternative would be using skb_orphan() and skb->destructor.
> There are other cases where skb's are not freed right away.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hi Stephen:

Do you mean registering a skb->destructor for pktgen then set and check 
bits in skb->tx_flag?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/