Re: [PATCH 1/1] gpio: Provide the STMPE GPIO driver with its own IRQ Domain

[Linus Walleij]

On Fri, Nov 23, 2012 at 4:19 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> The STMPE GPIO driver can be used as an IRQ controller by some
> related devices. Here we provide it with its very own IRQ Domain
> so that IRQs can be issued dynamically. This will stand the
> driver in good stead when it is enabled for Device Tree, as this
> it a prerequisite.
>
> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
> Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

The patch looks bogus since there is no code exercising the added
irqdomain code in this patch, it's basically a no-op in the irq
path, which is wrong for an irqdomain.

It is lacking a irq_create_mapping() in stmpe_gpio_to_irq(),
removal of the irq_base member and usage of
irq_find_mapping() in stmpe_gpio_irq().

Only then will the irqdomain actually be used for what it's
intended for.

So I get the impression that this is one of these "let's
just throw a dummy irqdomain in there so we can use
it with devicetree" kind of things...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/