Re: [PATCH 2/2] mm/migration: Make rmap_walk_anon() and try_to_unmap_anon()more scalable

[Rik van Riel]

On 12/01/2012 03:15 PM, Ingo Molnar wrote:

> Index: linux/include/linux/rmap.h
> ===================================================================
> --- linux.orig/include/linux/rmap.h
> +++ linux/include/linux/rmap.h
> @@ -128,6 +128,17 @@ static inline void anon_vma_unlock(struc
>   	up_write(&anon_vma->root->rwsem);
>   }
>
> +static inline void anon_vma_lock_read(struct anon_vma *anon_vma)
> +{
> +	down_read(&anon_vma->root->rwsem);
> +}

I see you did not rename anon_vma_lock and anon_vma_unlock
to anon_vma_lock_write and anon_vma_unlock_write.

That could get confusing to people touching that code in
the future.

The patch looks correct, though.

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/