Re: [PATCH] drivers:staging: fix compilation warning

From: Cong Ding
Date: Mon Dec 03 2012 - 06:04:20 EST


On Mon, Dec 03, 2012 at 01:56:09PM +0300, Dan Carpenter wrote:
> On Mon, Dec 03, 2012 at 10:34:08AM +0000, Cong Ding wrote:
> > We do not allow old-style function definition. Always spell foo(void) if
> > a function does not take any parameters.
> >
>
> You should be working against linux-next. This driver has been
> deleted in linux-next.
>
> The subject should have been:
> [PATCH] Staging: telephony/ixj: fix sparse warning
> or something like that. "drivers" is not useful. And Staging by
> itself is too broad.
>
> I think it's a Sparse warning, not a compile warning? Copy and
> paste the warning into the commit message.
sure, thanks for the suggestions.

- cong

>
> Anyway, since this was deleted it doesn't matter.
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/