Re: [PATCHv2 3/5] serial: 8250_dw: Map IO memory

From: Heikki Krogerus
Date: Tue Dec 04 2012 - 03:17:06 EST


Hi Jamie,

On Mon, Dec 03, 2012 at 03:40:14PM +0000, Jamie Iles wrote:
> > + uart.port.membase = ioremap(regs->start, regs->end - regs->start);
>
> Doesn't this have an off-by-one error?

True.

> + uart.port.membase = ioremap(regs->start, resource_size(regs));
>
> instead?

Yes, I'll fix this. Thanks!

--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/