Re: [PATCH] megaraid: fix use of delayed work

From: Tejun Heo
Date: Tue Dec 04 2012 - 10:57:32 EST


Hello, again, Xiaotian.

On Tue, Dec 04, 2012 at 07:39:39AM -0800, Tejun Heo wrote:
> Urgh... what the.... Didn't see that one coming. I'm gonna push this
> to Linus through the workqueue tree.
>
> Thanks for the fix.

It seems like megaraid doesn't have any reason to use delayed_work at
all. It can use a plain work and cancel_work_sync() instead. Maybe
it was doing the container_of() thing because workqueue didn't use to
have cancel_work_sync()? Anyways, please convert it to use plain
work_struct post 3.7.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/