Re: [PATCH 20/52] mm, numa: Implement migrate-on-fault lazy NUMAstrategy for regular and THP pages

[Mel Gorman]

On Tue, Dec 04, 2012 at 04:55:13PM -0800, David Rientjes wrote:
> Commit "mm, numa: Implement migrate-on-fault lazy NUMA strategy for 
> regular and THP pages" breaks the build because HPAGE_PMD_SHIFT and 
> HPAGE_PMD_MASK defined to explode without CONFIG_TRANSPARENT_HUGEPAGE:
> 
> mm/migrate.c: In function 'migrate_misplaced_transhuge_page_put':
> mm/migrate.c:1549: error: call to '__build_bug_failed' declared with attribute error: BUILD_BUG failed
> mm/migrate.c:1564: error: call to '__build_bug_failed' declared with attribute error: BUILD_BUG failed
> mm/migrate.c:1566: error: call to '__build_bug_failed' declared with attribute error: BUILD_BUG failed
> mm/migrate.c:1573: error: call to '__build_bug_failed' declared with attribute error: BUILD_BUG failed
> mm/migrate.c:1606: error: call to '__build_bug_failed' declared with attribute error: BUILD_BUG failed
> mm/migrate.c:1648: error: call to '__build_bug_failed' declared with attribute error: BUILD_BUG failed
> 
> CONFIG_NUMA_BALANCING allows compilation without enabling transparent 
> hugepages, so define the dummy function for such a configuration and only 
> define migrate_misplaced_transhuge_page_put() when transparent hugepages 
> are enabled.
> 
> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>

Thanks David. I pushed the equivalent for the balancenuma tree and
should be included in the balancenuma-v10 tag or mm-balancenuma-v10r3
branch at
git://git.kernel.org/pub/scm/linux/kernel/git/mel/linux-balancenuma.git

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/