Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

[David Howells]

Takashi Iwai <tiwai@xxxxxxx> wrote:

> From: Takashi Iwai <tiwai@xxxxxxx>
> Subject: [PATCH v2] MODSIGN: Avoid using .incbin in C source
> 
> Using the asm .incbin statement in C sources breaks any gcc wrapper which
> assumes that preprocessed C source is self-contained. Use a separate .S
> file to include the siging key and certificate.
> 
> Tested-by: Michal Marek <mmarek@xxxxxxx>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

Acked-by: David Howells <dhowells@xxxxxxxxxx>

> +#define GLOBAL(name)	\
> +	.globl ASM_SYMBOL(name);	\
> +	ASM_SYMBOL(name):

This should perhaps be moved into a global header.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/