Re: [PATCH 2/2] Documentation: add docs for 88pm80x dt

[Qing Xu]

On 12/06/2012 06:55 AM, Grant Likely wrote:
> On Wed,  5 Dec 2012 13:42:00 +0800, Qing Xu <qingx@xxxxxxxxxxx> wrote:
> > From: Qing Xu <qingx@xxxxxxxxxxx>
> >
> > Signed-off-by: Qing Xu <qingx@xxxxxxxxxxx>
> No commit text?
>
> This patch needs to be squashed together with the patch that changes the
> driver. There is no value in separating them.
>
> > ---
> >   Documentation/devicetree/bindings/mfd/88pm80x.txt |   52 +++++++++++++++++++++
> >   1 files changed, 52 insertions(+), 0 deletions(-)
> >   create mode 100644 Documentation/devicetree/bindings/mfd/88pm80x.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/88pm80x.txt b/Documentation/devicetree/bindings/mfd/88pm80x.txt
> > new file mode 100644
> > index 0000000..8a0ed07
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/88pm80x.txt
> > @@ -0,0 +1,52 @@
> > +* Marvell 88pm80x Power Management IC
> > +
> > +Required parent device properties:
> > +- compatible : "marvell,88pm80x"
> > +- reg : the I2C slave address for the 88pm80x chip
> > +- interrupts : IRQ line for the 88pm80x chip
> > +- interrupt-controller: describes the 88pm80x as an interrupt controller (has its own domain)
> > +- #interrupt-cells : should be 1.
> > +	- The cell is the 88pm80x local IRQ number
> > +
> > +Optional parent device properties:
> > +- marvell,88pm80x-irqmode: inicates whether interrupt status is cleared by read
> > +- marvell,88pm80x-poweraddr: 88pm80x are multi-chips solution. <reg> stores the I2C address
> > +				of one chip, and this property stores the I2C address of
> > +				power related chip.
> > +- marvell,88pm80x-gpadcaddr: 88pm80x are multi-chips solution. <reg> stores the I2C address
> > +				of one chip, and this property stores the I2C address of
> > +				gpadc related chip.
> If it is multichip, then I would expect either a separate node for each
> chip and these properties use phandles (instead of i2c addresses) to
> point to the other chip nodes.
>
> Alternately, if the cluster is described using a single node, then you
> can put all three i2c addresses into the 'reg' property.
>
> g.

combined to one patch. please help review again. Thanks!



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/