Re: [PATCH] x86: ptrace.c only needs export.h and not the fullmodule.h

From: Borislav Petkov
Date: Thu Dec 06 2012 - 11:17:17 EST


On Thu, Dec 06, 2012 at 06:33:42AM -0500, Paul Gortmaker wrote:
> Commit cb57a2b4cff7edf2a4e32c0163200e9434807e0a ("x86-32: Export
> kernel_stack_pointer() for modules") added an include of the
> module.h header in conjunction with adding an EXPORT_SYMBOL_GPL
> of kernel_stack_pointer.
>
> But module.h should be avoided for simple exports, since it in turn
> includes the world. Swap the module.h for export.h instead.

If this is the preferred include for EXPORT_SYMBOL* stuff now, maybe we
should hold this down somewhere in writing or add it to checkpatch?

Thanks.

--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/