Re: [PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

[Chris Wilson]

On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:
> 
> On Thu, 06 Dec 2012, Tim Gardner <tim.gardner@xxxxxxxxxxxxx> wrote:
> > +	if (!saved_mode) {
> > +		pr_err("i915: Could not allocate saved display mode.\n");
> 
> Please use DRM_ERROR().

Truthfully neither, but join the growing petition to get real errorcodes
back to userspace!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/