Re: [RFC PATCH v3 7/9] yield_to(), cpu-hotplug: Prevent offliningof other CPUs properly

[Oleg Nesterov]

On 12/10, Srivatsa S. Bhat wrote:
>
> On 12/10/2012 01:18 AM, Oleg Nesterov wrote:
> >> -		if (preempt && rq != p_rq)
> >> +		if (preempt && rq != p_rq && cpu_online(task_cpu(p)))
> >
> > Why do we need this change?
> >
> > Afaics, you could add BUG_ON(!cpu_online(...)) instead?
> >
> > I am just curious.
> >
>
> Oh, I think that's a remnant of v1 (which needed readers to use
> cpu_online_stable()). You're right, we don't need it.

Ah OK, thanks.

> Or we could put a
> BUG_ON instead, like you suggested.

IMHO it would be better to simply drop this chunk.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/