Re: [PATCH 1/4] perf hists: Exchange order of comparing items whencollapsing hists

From: Jiri Olsa
Date: Mon Dec 10 2012 - 08:44:40 EST


On Mon, Dec 10, 2012 at 05:29:54PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>
> When comparing entries for collapsing put the given entry first, and
> then the iterated entry. This is not the case of hist_entry__cmp()
> when called if given sort keys don't require collapsing. So change
> the order for the sake of consistency. It will be required for
> matching and/or linking multiple hist entries.
>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Stephane Eranian <eranian@xxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/