Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time

[Jonathan Cameron]

On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote:
> On 12/10/2012 10:26 PM, Alexander Holler wrote:
>> Am 10.12.2012 21:22, schrieb Lars-Peter Clausen:
>>> On 12/10/2012 08:45 PM, Alexander Holler wrote:
>>>> Am 10.12.2012 18:05, schrieb Lars-Peter Clausen:
>>>>
>>>>> Looks pretty good now. But there are still some IIO remnants which should be
>>>>> removed as well. Also the driver should move to drivers/rtc/ since, well,
>>>>> it's a rtc driver not a IIO driver.
>>>>
>>>> I think it still should be stick to iio, because that is where all HID
>>>> sensors currently are found and where the user would expect to find such
>>>> a driver.
>>>
>>> That's because all the current IIO sensor drivers fall in the IIO domain. This
>>> one clearly is a RTC driver, so it belongs in drivers/rtc/
>>
>> Where nobody will find it if he searches for drivers for his HID sensor.
>> I still see it as HID sensor driver and not a rtc-driver.
>> But ...
> 
> I can understand your position, but drivers are usually grouped by function not
> by topology. If there is a proper Kconfig help text people should hopefully be
> find it.
Seconded on this. If it is a pure rtc driver then it definitely belongs in
drivers/rtc.  Now there might have been ways of doing this as a consumer / provider
with the provider being in IIO and the consumer in rtc, but that sounds like
it is over compicating things, at least for now.

> 
>>
>>>
>>>>
>>>>>> +/* Channel definitions */
>>>>>> +static const struct iio_chan_spec hid_time_channels[TIME_RTC_CHANNEL_MAX] = {
>>>>
>>>> And that is imho the last remaining iio-stuff. If necessary I can remove
>>>> it too.
>>>
>>> That and the remaining bits of the read_raw callback.
>>
>> Ok. I will make a v3.
>>
> 
> Btw. have you seen the other comments I had inline in my response to your v2?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/