Re: [PATCH 1/1] gpio: add Lynxpoint chipset gpio driver.

[Linus Walleij]

On Mon, Dec 10, 2012 at 3:06 PM, Mathias Nyman
<mathias.nyman@xxxxxxxxxxxxxxx> wrote:

>>> +static void lp_irq_enable(struct irq_data *d)
>>> +{
>>> +       struct lp_gpio *lg = irq_data_get_irq_chip_data(d);
>>> +       u32 gpio = irqd_to_hwirq(d);
>>
>>
>> That variable is confusingly named. It's not a global gpio number,
>> it's a local offset, so please rename it "offset".
>
> sure, (is "pin" ok?  "offset" is already used in may places)

pin will confuse things to the pinctrl subsystem ... offset is really nice.
But no super-big deal.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/