Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics
From: Xishi Qiu
Date: Mon Dec 10 2012 - 21:25:24 EST
On 2012/12/10 23:38, Andi Kleen wrote:
>> It is another topic, I mean since the page is poisoned, so why not isolate it
>> from page buddy alocator in soft_offline_page() rather than in check_new_page().
>> I find soft_offline_page() only migrate the page and mark HWPoison, the poisoned
>> page is still managed by page buddy alocator.
>
> Doing it in check_new_page is the only way if the page is currently
> allocated by someone. Since that's not uncommon it's simplest to always
> do it this way.
>
> -Andi
>
Hi Andi,
The poisoned page is isolated in check_new_page, however the whole buddy block will
be dropped, it seems to be a waste of memory.
Can we separate the poisoned page from the buddy block, then *only* drop the poisoned
page?
Thanks
Xishi Qiu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/