Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

From: Al Viro
Date: Tue Dec 11 2012 - 09:58:50 EST


On Tue, Dec 11, 2012 at 09:56:21AM -0500, J. Bruce Fields wrote:

> That looks simpler, but I still don't understand why we need it.
>
> I'm confused about how d_path works; I would have thought that
> filesystem namespaces would have their own vfsmount trees and hence that
> the (vfsmount, dentry) would be enough to specify the path. Is the root
> argument for the case of chroot? Do we care about that?

__d_path() is relative pathname from here to there. Whether (and what for)
is it wanted in case of nfsd patches is a separate question...

> Also, svc_export_request is called from mountd's read of
> /proc/net/rpc/nfsd.export/channel. If mountd's root is wrong, then
> nothing's going to work anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/