Re: [PATCH v2 04/10] net: smc911x: use io{read,write}*_repaccessors

From: David Miller
Date: Tue Dec 11 2012 - 12:51:47 EST


From: Will Deacon <will.deacon@xxxxxxx>
Date: Tue, 11 Dec 2012 14:49:49 +0000

> On Mon, Dec 10, 2012 at 08:47:05PM +0000, David Miller wrote:
>> This misses the two uses in smsc911x_tx_writefifo and
>> smsc911x_rx_readfifo.
>
> Well spotted, updated patch below.

Although I'd like to take credit, the compiler told me :-)

> From b46e33465e755e945136d19938c9a8331cbafce7 Mon Sep 17 00:00:00 2001
> From: Matthew Leach <matthew@xxxxxxxxxxxxx>
> Date: Tue, 6 Nov 2012 14:51:11 +0000
> Subject: [PATCH v3] net: smc911x: use io{read,write}*_rep accessors
>
> The {read,write}s{b,w,l} operations are not defined by all
> architectures and are being removed from the asm-generic/io.h
> interface.
>
> This patch replaces the usage of these string functions in the smc911x
> accessors with io{read,write}{8,16,32}_rep calls instead.
>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Ben Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Matthew Leach <matthew@xxxxxxxxxxxxx>
> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/