Re: [PATCH 0/2] ima: policy search speedup

[Linus Torvalds]

On Tue, Dec 11, 2012 at 12:15 PM, Eric Paris <eparis@xxxxxxxxxxxxxx> wrote:
>
> I know it isn't relevant to the final solution, but this is simply
> wrong.  IS_PRIVATE() means 'this inode is filesystem internal.'  It is
> not used by anything except rieser and the anon_inode.  If it is used
> by psuedo filesystems in general, like /proc, shmem mappings, and
> pipes that is a huge bug and is absolutely wrong.

Hmm.. The magic anonfs inode definitely sets it, as far as I can tell.

But it turns out that I was wrong anyway, and you are largely right:
pipes and sockets don't use the anonfs inode (they allocate their own
inodes directly using 'new_inode_pseudo()'), and neither does /proc.

So it's actually only signalfd and timerfd and some other special
things like kvm internal file descriptors that use it.

So never mind about S_PRIVATE, it has odd semantics.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/