Re: [PATCH v2 0/3] gpio: twl4030: Correct status reporting for outputs

[Peter Ujfalusi]

Hi Grant,

On 12/07/2012 09:09 AM, Linus Walleij wrote:
> On Thu, Dec 6, 2012 at 11:52 AM, Peter Ujfalusi <peter.ujfalusi@xxxxxx> wrote:
> 
>> As Grant commneted on the first version:
>> https://lkml.org/lkml/2012/12/5/53
>>
>> Introduce bitfields to cache the directionand output status of the pins so we
>> can report them correctly.
>> To do this I did some cleanup within the driver to get rid of the global
>> variables and moved them under a private structure, changed the locking as well
>> to protect the bitfield operation.
>> As a last patch I added a note that the PWMA/B handling should not be in this
>> driver at all.
> 
> This looks good to me:
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> Since Grant was requesting the changes I'll let him decide to merge.

Would you have time to take a look at this set?

Thanks,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/