Re: [PATCH] drivers/pinctrl: grab default handles from device core

From: Linus Walleij
Date: Wed Dec 12 2012 - 14:56:31 EST


On Tue, Dec 11, 2012 at 7:13 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote:
>> diff --git a/include/linux/device.h b/include/linux/device.h

>> +#ifdef CONFIG_PINCTRL
>> + struct dev_pin_info pins;
>> +#endif
>
> Can't you just make this a * to the structure, saving a bit of space for
> those that don't use this structure? Ok, it's only saving one pointer,
> so it's really not a big deal to me if you don't want to do this, just
> asking...

OK I'll look into it.

> Also, this will have to wait until after 3.8-rc1 before I can consider
> merging it, I'm a bit busy for the next two weeks at the least...

Sure. I'm mainly seeking an ACK so I can take it through the pinctrl
subsystem in any case, as I will probably stick a few dependencies
in there. And it'll certainly be for v3.9.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/