Re: [PATCH 0/5] [GIT PULL] ktest: fixes and updated for new bootloaders

[Steven Rostedt]

On Thu, 2012-12-13 at 10:47 +1100, Stephen Rothwell wrote:
> Hi Steve,
> 
> On Wed, 12 Dec 2012 17:14:37 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > Please pull the latest ktest-v3.8 tree, which can be found at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest.git
> > ktest-v3.8
> > 
> > Head SHA1: a7c85ac16cf29aa0fec5fef2fe26bb09a9e3ee19
> > 
> > 
> > Steven Rostedt (5):
> >       ktest: Add support for grub2
> >       ktest: Sync before reboot
> >       ktest: Add native support for syslinux boot loader
> >       ktest: Fix breakage from change of oldnoconfig to olddefconfig
> >       ktest: Test if target machine is up before install
> 
> Just a bit disappointed that none of this made ever it into your for-next
> branch (and hence linux-next) ...
> 

Yeah, I know. That's because most of it stays in a quilt queue and I
commit it to git when the merge window opens. I use ktest every day, and
hammer it more than anyone else. I usually shake out all the bugs before
I post.

As this sits in the tools/testing/ktest/ directory and is just a single
perl script, it doesn't interact with other parts of the kernel tree.
I've been trying to remember to add it to linux-next, but sometimes I
forget :-(

My work flow with ktest is basically this:

1) Something about ktest bothers me

2) I write up a new feature

3) Test it a bit, and then make it into a quilt patch

4) After using it for a while, I'll do the git commit and push
   it off to linux-next

5) Merge window opens, I look at both my commits and my quilt queue
   and commit any missing patches that I feel is good enough

6) Push the entire thing off to Linus


ktest is very low on my priority list of things to maintain, and I
sometimes forget step 4. But I don't worry too much because it may miss
out on some testing, but if it breaks, it will only break ktest. It
shouldn't break anything else in the kernel.

And actually, I admit the last 3 patches of the series was written in
the last week and the other 2 a couple of weeks before that, as I was
adding a new machine to my test suite and added a Fedora 17 image for
the first time (first one without grub1 and with systemd), that it
caused me a lot of pain with my automated testing. I struggled with
grub2, got it mostly working, but then decided recently to just use
syslinux. I also just noticed the breakage that was there from the last
release, where the make oldnoconfig was changed. Hmm, maybe I should
look at linux-next more often, to see if anyone is touching ktest
without telling me.

I'll try to be better next time :-)  (no pun intended)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/