Re: [patch 6/8] mm: vmscan: clean up get_scan_count()
From: Mel Gorman
Date: Thu Dec 13 2012 - 06:07:56 EST
On Wed, Dec 12, 2012 at 04:43:38PM -0500, Johannes Weiner wrote:
> Reclaim pressure balance between anon and file pages is calculated
> through a tuple of numerators and a shared denominator.
> Exceptional cases that want to force-scan anon or file pages configure
> the numerators and denominator such that one list is preferred, which
> is not necessarily the most obvious way:
> fraction = 1;
> fraction = 0;
> denominator = 1;
> goto out;
> Make this easier by making the force-scan cases explicit and use the
> fractionals only in case they are calculated from reclaim history.
> And bring the variable declarations/definitions in order.
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>
Acked-by: Mel Gorman <mgorman@xxxxxxx>
The if at the end looks like it should have been a switch maybe?
/* Scan relative to size */
/* Scan proportional to swappiness */
scan = div64_u64(scan * fraction[file], denominator);
/* Scan only file or only anon LRU */
if ((scan_balance == SCAN_FILE) != file)
scan = 0;
/* Look ma, no brain */
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/