Re: [Suggestion] drivers/staging/tidspbridge: pr_err and pr_debugfor uninitialized buffer (name buf not initialized).

From: Chen Gang
Date: Thu Dec 13 2012 - 20:29:12 EST


ä 2012å12æ14æ 02:25, Omar Ramirez Luna åé:
> Hi Chen,
>
> Thanks for your report.
>
> On Wed, Dec 12, 2012 at 4:12 AM, Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
>> excuse me, I have to forward this mail to you.
>> I have sent it to Omar Ramirez Luna <omar.ramirez@xxxxxx>, but failed.
>> (get mail delivery failed )
>
> Please contact me with my new address (this one).

is it suitable to modify the MAINTAINER file for your mail address ?
if suitable, please help modify it, I am not quite familiar with it.

also another suggestions:
I built ti otmap with ti dsp bridge by arm cross-compiler under i386 platform.
the version tag is next-20121213
I met 2 compiling issues.

a: module dependency:
Multifunction device drivers --> Texas Instruments TWL/4030/TWL5030.... is required for TI OTMAP.
it need depend on CONFIG_REGMAP (maybe also inculde CONFIG_REGMAP*)
if CONFIG_REGMAP* not defined, building will be failed.

b: version merging issue:
in drivers/staging/tidspbridge/core/_tiomap.h
need use "#include <mach-omap2/cm3xxx.h>" instead of "#include <mach-omap2/cm2xxx_3xxx.h>"
the macro OMAP3430_CM_AUTOIDLE_PLL has already move from cm2xxx_3xxx.h to cm3xxx.h.
(it seems arch/arm/mach-omap2/ is not a suitable place for including, but we have to)
if not change, compiling will be failed.

please also help to check the 2 compiling issues, thanks.

if these suggestions are valid,
please help to send patches for them,
better to mark me as Reported-by.
not need cc to me (for I am not reviewer)


Regards

gchen.


>
> I'll take a look at these.
>
> Cheers,
>
> Omar
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>


--
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/