Re: [PATCH v2 00/10] kvm: memory slot cleanups, fix, and increase

From: Marcelo Tosatti
Date: Fri Dec 14 2012 - 20:24:00 EST


On Mon, Dec 10, 2012 at 10:32:39AM -0700, Alex Williamson wrote:
> v2: Update 02/10 to not check userspace_addr when slot is removed.
> Yoshikawa-san withdrew objection to increase slot_bitmap prior
> to his series to remove slot_bitmap.
>
> This series does away with any kind of complicated resizing of the
> slot array and simply does a one time increase. I do compact struct
> kvm_memory_slot a bit to take better advantage of the space we are
> using. This reduces each slot from 64 bytes (x86_64) to 56 bytes.
> By enforcing the API around valid operations for an unused slot and
> fields that can be modified runtime, I found and was able to fix a
> bug in iommu mapping for slots. The renames enabled me to find the
> previously posted bug fix for catching slot overlaps.
>
> As mentioned in the series, the primary motivation for increasing
> memory slots is assigned devices. With this, I've been able to
> assign 30 devices to a single VM and could have gone further, but
> ran out of SRIOV VFs. Typical devices use anywhere from 2-4 slots
> and max out at 8 slots. 125 user slots (3 private slots) allows
> us to support between 28 and 56 typical devices per VM.
>
> Tested on x86_64, compiled on ia64, powerpc, and s390.
>
> Thanks,
> Alex

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/