Re: [PATCH 2/2] spi: devicetree: add support for loopback mode

[Felipe Balbi]

On Sat, Dec 15, 2012 at 12:32:24AM +0000, Grant Likely wrote:
> On Wed, 12 Dec 2012 10:46:00 +0200, Felipe Balbi <balbi@xxxxxx> wrote:
> > there are a few spi master drivers which make
> > use of that flag but there is no way to pass it
> > through devicetree.
> > 
> > This patch just creates a way to pass SPI_LOOP
> > via devicetree.
> 
> I don't understand how this would be useful since loopback mode is
> really just a test feature. Is there any reason to do loopback for
> something other than test?
> 
> I think it would be better to add a sysfs or debugfs property to
> manipulate the SPI_LOOP flag from userspace. What do you think?

might be nicer in the long run, indeed. Want me to look into it, or do
you wanna do it yourself ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature