Re: [PATCH] fadvise: perform WILLNEED readahead in a workqueue

From: Eric Wong
Date: Sat Dec 15 2012 - 22:09:13 EST


Eric Wong <normalperson@xxxxxxxx> wrote:
> Perhaps squashing something like the following will work?

Last hunk should've had a return before skip_ra:

--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -264,6 +266,10 @@ void wq_page_cache_readahead(struct address_space *mapping, struct file *filp,
req->nr_to_read = nr_to_read;

queue_work(readahead_wq, &req->work);
+
+ return;
+skip_ra:
+ fput(filp);
}

/*
--
Eric Wong
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/